uros-b commented on code in PR #56622:
URL: https://github.com/apache/spark/pull/56622#discussion_r3447568566
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala:
##########
@@ -1376,6 +1388,17 @@ class ExpressionParserSuite extends AnalysisTest {
fragment = "time '12-13.14'",
start = 0,
stop = 14))
+
+ // More than 9 fractional-second digits is rejected.
Review Comment:
One question here about Cast vs. literal handling of >9 fractional digits.
Right now, it seems a bit inconsistent. e.g. CAST('12:34:56.1234567890' AS
TIME(9)) silently drops digits beyond the 9th (per parseTimestampString), while
the literal TIME '12:34:56.1234567890' raises INVALID_TIME_LITERAL_PRECISION.
Is this intentional and consistent with rest of the codebase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
