MaxGekk commented on code in PR #56622: URL: https://github.com/apache/spark/pull/56622#discussion_r3447603488
########## sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkDateTimeUtils.scala: ########## Review Comment: Good catch - done in a9f4569. `truncateTimeToPrecision` now indexes a precomputed power-of-ten table instead of calling `math.pow` per value (helps the row-converter and cast paths too), and the vectorized `TimeUpdater` hoists the factor into its constructor via a `long[]` lookup, so the hot decode loop is pure long arithmetic with no per-value `pow`/assert. The factor table's length encodes `NANOS_PRECISION`, so the Java side needs no cross-language constant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
