shrirangmhalgi commented on PR #56637: URL: https://github.com/apache/spark/pull/56637#issuecomment-4762549632
Thanks @MaxGekk for the review. All addressed in the latest commit: - Switched to `AnyTimeType` from TimeType. Good catch, `TIME(3)` / `TIME(0)` would have failed at analysis otherwise. - Pinned the test to `DateTimeException` and added a `TIME(0)` precision regression test - Renamed `timeMicros` → `timeNanos` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
