shrirangmhalgi commented on PR #56637: URL: https://github.com/apache/spark/pull/56637#issuecomment-4772802624
Thank you @MaxGekk. All concerns addressed in the latest commit: - `prettyName` instead of literal `"to_char"` - now reports the correct function name for `date_format` / `to_varchar` too - Removed dead `errClass` val - Fixed scaladoc to reflect both eval and codegen usage - Also replaced the `regexp` parameter with format by constructing the `SparkRuntimeException` directly - the error message now reads correctly for a datetime context -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
