shrirangmhalgi commented on PR #56653: URL: https://github.com/apache/spark/pull/56653#issuecomment-4773917927
Thank you @MaxGekk for the review. Addressed all the points in the latest commit: - DDL now emits `TIME(p)` preserving precision. - Round-trip test uses sub-second value (LocalTime.of(23, 59, 59, 123456000)) - `scale >= 0` so `TIME(0)` infers correctly. - Re: getter storing full nanos — intentional, same as `TimestampType` which stores full micros regardless of source precision. The declared precision is metadata for display/comparison, not a storage constraint. - Also fixed CI: integration tests wrapped with `timeType.enabled=false` to preserve legacy behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
