shrirangmhalgi commented on code in PR #56653:
URL: https://github.com/apache/spark/pull/56653#discussion_r3460794359
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala:
##########
@@ -164,6 +164,7 @@ object JdbcUtils extends Logging with SQLConfHelper {
// Note that some dialects override this setting, e.g. as SQL Server.
case TimestampNTZType => Option(JdbcType("TIMESTAMP",
java.sql.Types.TIMESTAMP))
case DateType => Option(JdbcType("DATE", java.sql.Types.DATE))
+ case t: TimeType => Option(JdbcType(s"TIME(${t.precision})",
java.sql.Types.TIME))
Review Comment:
Ack. Thanks for flagging. I agree - clamping to each dialect's max precision
belongs in the per-dialect follow-ups. Will make sure to follow this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
