MaxGekk commented on PR #56697:
URL: https://github.com/apache/spark/pull/56697#issuecomment-4778474808
The CI failures in `SQLQueryTestSuite.xml-functions.sql` and
`ThriftServerQueryTestSuite.xml-functions.sql` are caused by this PR and just
need a golden-file regen.
The new TIME inference correctly changes the inferred type of a bare time
string from `TIMESTAMP` to `TIME(6)`, but `xml-functions.sql.out` still
hard-codes the old expectation for the two `schema_of_xml` queries:
```
Expected "STRUCT<time: TIMESTAMP>", but got "STRUCT<time: TIME(6)>"
select schema_of_xml('<record><time>14:30:45</time></record>', map('rowTag',
'record'))
```
Affected lines (both should now be `STRUCT<time: TIME(6)>`):
- `sql/core/src/test/resources/sql-tests/results/xml-functions.sql.out:639`
(`schema_of_xml('...14:30:45...')`)
- `sql/core/src/test/resources/sql-tests/results/xml-functions.sql.out:647`
(`schema_of_xml('...14:30:45.123456...')`)
Could you regenerate the golden file (don't hand-edit it) and review the
diff?
```
SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/testOnly
org.apache.spark.sql.SQLQueryTestSuite -- -z xml-functions"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
