uros-b commented on code in PR #56697:
URL: https://github.com/apache/spark/pull/56697#discussion_r3460536298
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/xml/XmlInferSchemaSuite.scala:
##########
@@ -646,6 +648,50 @@ class XmlInferSchemaSuite
assert(xmlDF.schema === expectedSchema)
checkAnswer(xmlDF, expectedAns)
}
+
+ test("TIME type inference") {
+ val xmlString = Seq("""<ROW><t>13:31:24.123456</t></ROW>""")
+ val df = readData(xmlString)
+ assert(df.schema === new StructType().add("t",
TimeType(TimeType.DEFAULT_PRECISION)))
+ checkAnswer(df, Row(java.time.LocalTime.of(13, 31, 24, 123456000)))
+ }
+
+ test("TIME type inference - disabled when timeType.enabled is false") {
Review Comment:
The disabled test could be stronger. When timeType.enabled=false, 13:31:24
should fall through to TimestampType (same as CSV), not just “not TIME”.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
