cloud-fan opened a new pull request, #56752: URL: https://github.com/apache/spark/pull/56752
### What changes were proposed in this pull request? Add a new `## Checking If and Where a PR Was Merged` section to `AGENTS.md` (`CLAUDE.md` is a symlink to it), slotted between the existing "Pull Request Workflow" and "Versioning and Branch Policy" sections. The new section documents: - Spark merges PRs with `dev/merge_spark_pr.py`, not the GitHub merge button, so a merged PR appears on GitHub as **Closed**, not **Merged** (empty `merged` / `mergedAt`, no linked merge commit), and maintenance-branch backports are plain cherry-pick pushes invisible to the PR's merge metadata. - How to reliably determine the merge commit and which branches a PR landed on, using the `Closes #<pr> from <author>/<branch>` trailer that the merge script writes (and every cherry-pick retains), together with `git log --all --grep`, `git merge-base --is-ancestor`, and the GitHub PR timeline (`closed` / `referenced` events) as an equivalent source of truth. ### Why are the changes needed? A merged Spark PR shows up as "Closed" on GitHub rather than "Merged", which is routinely misread -- by AI coding agents in particular, but also by newcomers -- as the PR having been rejected. There is also no obvious, documented way to check whether (and to which branches: `master`, `branch-4.x`, maintenance lines) a given PR was actually merged. `AGENTS.md` already documents the PR workflow and the versioning/branch policy; this fills the adjacent gap so agents and contributors stop drawing the wrong conclusion and have a concrete procedure to verify merge status. ### Does this PR introduce _any_ user-facing change? No. Documentation-only change to `AGENTS.md`. ### How was this patch tested? Documentation-only change; no code paths affected. The git commands described in the new section (`git log --all --oneline --grep "Closes #<pr> from "`, `git merge-base --is-ancestor <commit> upstream/<branch>`) were exercised against real merged Spark PRs to confirm they correctly identify the merge commit and the branches a PR landed on. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.8) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
