MaxGekk commented on PR #56752: URL: https://github.com/apache/spark/pull/56752#issuecomment-4793482631
I found two small documentation issues: 1. The new section says the GitHub PR timeline is an "equivalent source of truth" for where a PR landed. That seems a bit too strong: `referenced` events can identify candidate cherry-pick commits, but they do not by themselves prove branch containment or that the change was not later reverted. The `git log` + `git merge-base --is-ancestor` + revert check procedure should remain the authoritative guidance, with the timeline described as supporting evidence. 2. The PR description appears stale relative to the current patch. It says the section is titled `Checking If and Where a PR Was Merged` and is placed between "Pull Request Workflow" and "Versioning and Branch Policy", but the current diff adds `Checking PR Merge Status` before "Pull Request Workflow". The core trailer guidance matches `dev/merge_spark_pr.py`: it writes `Closes #<pr> from <author>/<branch>.`, and cherry-picks use `git cherry-pick -sx`, so the main `git log --grep` approach looks sound. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
