uros-b commented on code in PR #56736:
URL: https://github.com/apache/spark/pull/56736#discussion_r3472537560
##########
core/src/main/scala/org/apache/spark/deploy/Client.scala:
##########
@@ -180,11 +180,14 @@ private class ClientEndpoint(
System.exit(-1)
case _ =>
state.get match {
- case DriverState.FINISHED | DriverState.FAILED |
- DriverState.ERROR | DriverState.KILLED =>
+ case DriverState.FINISHED =>
logInfo(log"State of driver ${MDC(DRIVER_ID,
submittedDriverID)}" +
log" is ${MDC(DRIVER_STATE, state.get)}, exiting spark-submit
JVM.")
System.exit(0)
+ case DriverState.FAILED | DriverState.ERROR | DriverState.KILLED =>
Review Comment:
ClientSuite.scala has zero coverage of reportDriverStatus, and the logic
calls System.exit directly (no injectable exitFn) so it is untestable as
written. "Relying on existing CI integration test suites" is not credible as a
testing strategy; please consider an injectable exit hook + a
terminal-state→exit-code unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
