uros-b commented on code in PR #56736:
URL: https://github.com/apache/spark/pull/56736#discussion_r3472542656
##########
core/src/main/scala/org/apache/spark/deploy/Client.scala:
##########
@@ -180,11 +180,14 @@ private class ClientEndpoint(
System.exit(-1)
case _ =>
state.get match {
- case DriverState.FINISHED | DriverState.FAILED |
- DriverState.ERROR | DriverState.KILLED =>
+ case DriverState.FINISHED =>
logInfo(log"State of driver ${MDC(DRIVER_ID,
submittedDriverID)}" +
log" is ${MDC(DRIVER_STATE, state.get)}, exiting spark-submit
JVM.")
System.exit(0)
+ case DriverState.FAILED | DriverState.ERROR | DriverState.KILLED =>
+ logError(log"State of driver ${MDC(DRIVER_ID,
submittedDriverID)}" +
+ log" is ${MDC(DRIVER_STATE, state.get)}, exiting
spark-submit JVM.")
Review Comment:
Failure-arm log message reused verbatim from the success branch ("...exiting
spark-submit JVM."); a distinct error message would aid operators/log analysis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
