uros-b commented on code in PR #56775:
URL: https://github.com/apache/spark/pull/56775#discussion_r3474850478
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala:
##########
@@ -2627,8 +2635,8 @@ private[sql] object QueryExecutionErrors extends
QueryErrorsBase with ExecutionE
summary = "")
}
- def timestampNanosEpochNanosOverflowError(
- value: TimestampNanosVal, isNtz: Boolean, sink: String):
SparkArithmeticException = {
+ def parquetTimestampNanosOverflowError(
Review Comment:
The PR renames timestampNanosEpochNanosOverflowError(value, isNtz, sink) ->
parquetTimestampNanosOverflowError(value, isNtz) and hardcodes "Parquet INT64",
but does NOT update its 3 call sites (ArrowWriter.scala:406, :426;
ParquetWriteSupport.scala:199). The build will likely NOT compile. Also, this
rename is entirely unrelated to SPARK-21529; pure scope creep / accidental
edit; should very likely be reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
