HyukjinKwon commented on code in PR #56775:
URL: https://github.com/apache/spark/pull/56775#discussion_r3478176369
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -8561,7 +8561,12 @@
],
"sqlState" : "0A000"
},
- "UNSUPPORTED_INSERT" : {
+ "UNSUPPORTED_HIVE_TYPE" : {
+ "message" : [
+ "Cannot read the Hive type <fieldType> of the column <fieldName> because
Spark SQL does not support this data type."
Review Comment:
A few lines below this, the new entry closes as:
```
}, "UNSUPPORTED_INSERT" : {
```
i.e. the `UNSUPPORTED_HIVE_TYPE` closing brace and the next error key are on
the same line (missing newline). `SparkThrowableSuite`'s "Error conditions are
correctly formatted" test re-serializes the error map with a pretty-printer
(one key per line) and asserts the file matches exactly, so this will fail CI:
```
},
"UNSUPPORTED_INSERT" : {
```
Alphabetical placement (HIVE_TYPE before INSERT) is correct — only the line
break is missing. Re-running `SPARK_GENERATE_GOLDEN_FILES=1 …
SparkThrowableSuite -- -t "Error conditions are correctly formatted"`
regenerates it correctly. (Otherwise the detection logic and tests look good,
and the unrelated `timestampNanos…` rename is reverted here.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
