uros-b commented on code in PR #56792:
URL: https://github.com/apache/spark/pull/56792#discussion_r3481101488
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteDeleteFromTable.scala:
##########
@@ -45,7 +44,7 @@ object RewriteDeleteFromTable extends RewriteRowLevelCommand {
d
case r @ ExtractV2Table(t: SupportsRowLevelOperations) =>
Review Comment:
Please consider this concern: silent option-drop on non-rewrite delete
paths: for a table implementing both SupportsRowLevelOperations and
SupportsDeleteV2 (e.g. Iceberg), a DELETE … WITH(...) WHERE <pushable> can take
the metadata-only/deleteWhere path (OptimizeMetadataOnlyDeleteFromTable /
DataSourceV2Strategy), which has no options parameter; so the user's options
are silently ignored. Same for the TruncatableTable truncate path. This would
be a new user-visible "silently ignored" surprise, and no test currently covers
this path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
