dongjoon-hyun commented on code in PR #56792:
URL: https://github.com/apache/spark/pull/56792#discussion_r3509289787
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -740,7 +740,7 @@ dmlStatementNoWith
: insertInto (query | LEFT_PAREN query RIGHT_PAREN queryAlias=tableAlias)
#singleInsertQuery
| fromClause multiInsertQueryBody+
#multiInsertQuery
| DELETE FROM identifierReference tableAlias whereClause?
#deleteFromTable
- | UPDATE identifierReference tableAlias setClause whereClause?
#updateTable
+ | UPDATE identifierReference optionsClause? tableAlias setClause
whereClause? #updateTable
Review Comment:
Although this seems to follow read path, this is inconsistent with our
existing `INSERT` syntax.
https://github.com/apache/spark/blob/972f6962e1a27b6892e51878ab21babd95b03e80/sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4#L592-L595
`UPDATE` should follow `INSERT` style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
