uros-b commented on code in PR #56874:
URL: https://github.com/apache/spark/pull/56874#discussion_r3496967624
##########
sql/pipelines/src/test/scala/org/apache/spark/sql/pipelines/graph/ConnectInvalidPipelineSuite.scala:
##########
@@ -764,4 +764,15 @@ class ConnectInvalidPipelineSuite extends PipelineTest
with SharedSparkSession {
)
)
}
+
+ test("DUPLICATE_GRAPH_ELEMENT: duplicate graph element identifiers") {
+ checkError(
+ exception = intercept[AnalysisException] {
+ DataflowGraph.mapUnique(Seq("a", "a"), "view")(identity)
Review Comment:
Minor coverage gap: test calls mapUnique(Seq("a","a"), "view")(identity)
with raw String keys, sidestepping the production convention where f =
_.identifier yields a TableIdentifier (whose toString is a qualified name). It
does reach the throw path and verifies the registration (the actual fix), but
no end-to-end duplicate-view/table pipeline exercises the real call sites.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
