ericm-db commented on PR #56907: URL: https://github.com/apache/spark/pull/56907#issuecomment-4860346035
Added a regression test for this in 321128d (`test_terminate_reaps_daemon_and_jvm`): it starts the detached daemon, waits until it has actually spawned its child JVM, then calls `_terminate_local_connect_server` and asserts the whole process group is gone (`os.killpg(pgid, 0)` raises `ProcessLookupError`). POSIX-only, since the process-group reaping is POSIX-specific. Also tightened the test `tearDown` to wait for the server port to close after stopping, so a stopped server's JVM can't linger into the next test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
