dongjoon-hyun commented on PR #56792: URL: https://github.com/apache/spark/pull/56792#issuecomment-4860450375
I finished the second-round review, @anuragmantri . - Please follow `INSERT`'s syntax instead of `SELECT` (https://github.com/apache/spark/pull/56792#discussion_r3509289787). `tableAlias` should come first. - Please double-check `RelationResolution` class. Especially, subqueries and CTE cases (https://github.com/apache/spark/pull/56792#pullrequestreview-4613106499) At least, this PR should add a test coverage to clarify what is supposed by this PR. - And, a minor comment about test prefixes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
