gaogaotiantian commented on PR #57040: URL: https://github.com/apache/spark/pull/57040#issuecomment-4901385137
Python 3.8 has been end of life for more than 2 years yet we still ran tests with it at least until a few weeks ago. We still use Python 3.9 as the major python version to test spark 3.5 and it has been EOL for about a year too. I can list a bunch of unpatched CVEs for Python 3.9 too because it's not maintained anymore. It's not my imagination that Apache Spark is still using it in their github actions. I won't be surprised at all if there are some users that have a pinned Python version that's old because that happens to be the version when they pinned it. It's about what we claim to support and what we do support. I'm okay if we say in our documentation that we only support Python 3.11 that's greater than 3.11.4 - that's fine. But if we claim to support 3.11, we should not have something in our install script that won't work in 3.11.0. More importantly, what do we lose if we check the version? Would it be a worse experience for users if we generate an exception with a better explanation of what's happening and how to deal with it? Will the code be less maintainable with the extra if statement which could be easily removed when we do not support 3.11 anymore? What's the reason not to do the safety check when we know that there are cases where this won't work? Because we are absolutely sure that there is no user out there that's using old Python version? Or we should not care about them because they are not serious users that upgrade their Python version frequently? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
