sarutak commented on code in PR #57066:
URL: https://github.com/apache/spark/pull/57066#discussion_r3535425670
##########
project/MimaExcludes.scala:
##########
@@ -43,7 +43,9 @@ object MimaExcludes {
ProblemFilters.exclude[FinalMethodProblem](
"org.apache.spark.ml.recommendation.ALS.intermediateStorageLevel"),
ProblemFilters.exclude[FinalMethodProblem](
- "org.apache.spark.ml.recommendation.ALS.getIntermediateStorageLevel")
+ "org.apache.spark.ml.recommendation.ALS.getIntermediateStorageLevel"),
+ // [SPARK-57987] Add desc field to the SQL REST API Node case class
+ ProblemFilters.exclude[Problem]("org.apache.spark.status.api.v1.sql.Node*")
Review Comment:
nit: Can we narrow this to specific problem types?
This would still allow MiMa to catch unexpected issues (like class removal)
while permitting the case class field addition. Not blocking, just a suggestion
for future-proofing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]