pan3793 commented on code in PR #57066: URL: https://github.com/apache/spark/pull/57066#discussion_r3541058202
########## sql/core/src/main/scala/org/apache/spark/status/api/v1/sql/api.scala: ########## @@ -20,6 +20,15 @@ import java.util.Date import org.apache.spark.sql.execution.ui.SparkPlanGraphEdge +case class Metric private[spark] (name: String, value: String) Review Comment: so essential change here are: - add `desc: String = null` to `case class Node` - add `val modifiedConfigs: Map[String, String] = Map.empty)` to `class ExecutionData` how about also exposing `planId` to `Node`, I found that sometimes the LLM might confuse about `nodeId` and `planId` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
