dongjoon-hyun commented on code in PR #749: URL: https://github.com/apache/spark-kubernetes-operator/pull/749#discussion_r3540429465
########## docs/config_properties.md: ########## @@ -38,9 +38,11 @@ | spark.kubernetes.operator.periodicGC.intervalSeconds | Long | 1800 | true | Interval (in seconds) between periodic System.gc() invocations. Set to 0 or a negative value to disable. Note that System.gc() is a no-op if JVM is started with -XX:+DisableExplicitGC. | | spark.kubernetes.operator.reconciler.appStatusListenerClassNames | String | | false | Comma-separated names of SparkAppStatusListener class implementations | | spark.kubernetes.operator.reconciler.clusterStatusListenerClassNames | String | | false | Comma-separated names of SparkClusterStatusListener class implementations | + | spark.kubernetes.operator.reconciler.defaultRequeueIntervalSeconds | Integer | 15 | true | Default requeue interval (in seconds) used for short-lived requeues while waiting for a transient condition to clear, e.g., for the pod informer cache to catch up during the missing-driver grace period. Distinct from spark.kubernetes.operator.reconciler.intervalSeconds, which controls the steady-state periodic reconcile cadence. | Review Comment: `defaultRequeueIntervalSeconds` is very misleading because it's not the real default. It's only used for missing driver cases. The real default is `reconciler.intervalSeconds` in `completeAndDefaultRequeue` method. https://github.com/apache/spark-kubernetes-operator/blob/1127bf9fee08b55251401b86c847e6646b520c98/spark-operator/src/main/java/org/apache/spark/k8s/operator/reconciler/ReconcileProgress.java#L65-L68 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
