dongjoon-hyun commented on code in PR #749:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/749#discussion_r3561872323
##########
spark-operator/src/main/java/org/apache/spark/k8s/operator/config/SparkOperatorConf.java:
##########
@@ -220,6 +199,47 @@ public final class SparkOperatorConf {
.defaultValue(120L)
.build();
+ /**
+ * Grace period (in seconds) the operator waits for the pod informer cache
to catch up
+ * after the driver pod is observed missing, before doing a live API
verification. Brief
+ * cache lag during pod creation/update event propagation is normal; only
sustained absence
+ * triggers an apiserver lookup. Set to 0 to verify on every cache miss.
+ */
+ public static final ConfigOption<Integer>
MISSING_DRIVER_GRACE_PERIOD_SECONDS =
+ ConfigOption.<Integer>builder()
+
.key("spark.kubernetes.operator.reconciler.missingDriverGracePeriodSeconds")
+ .enableDynamicOverride(true)
+ .description(
+ "Grace period (in seconds) the operator waits for the pod
informer cache to "
+ + "catch up after the driver pod is observed missing, before
doing a live "
+ + "API verification against the Kubernetes apiserver. This
protects healthy "
+ + "applications from being failed when the informer cache is
briefly stale "
+ + "(e.g., after a watch reconnect). Set to 0 to verify on
every cache miss.")
+ .typeParameterClass(Integer.class)
+ .defaultValue(60)
+ .build();
+
+ /**
+ * Requeue interval (in seconds) used to re-check a driver pod that is
missing from the informer
+ * cache, while waiting for the cache to catch up during the missing-driver
grace period. This is
+ * specific to the missing-driver flow and is not the operator's default
requeue cadence; the
+ * steady-state periodic reconcile interval is {@link
#RECONCILER_INTERVAL_SECONDS}.
+ */
+ public static final ConfigOption<Integer>
MISSING_DRIVER_REQUEUE_INTERVAL_SECONDS =
+ ConfigOption.<Integer>builder()
+
.key("spark.kubernetes.operator.reconciler.missingDriverRequeueIntervalSeconds")
+ .enableDynamicOverride(true)
+ .description(
+ "Requeue interval (in seconds) used to re-check a driver pod
that is missing from "
+ + "the informer cache, while waiting for the cache to catch
up during the "
+ + "missing-driver grace period. Specific to the
missing-driver flow; this is "
+ + "not the operator's default requeue cadence. The
steady-state periodic "
+ + "reconcile interval is
spark.kubernetes.operator.reconciler.intervalSeconds.")
+ .typeParameterClass(Integer.class)
+ .defaultValue(15)
+ .build();
+
+
Review Comment:
Redundant empty line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
