HyukjinKwon commented on code in PR #57079:
URL: https://github.com/apache/spark/pull/57079#discussion_r3555617166
##########
sql/api/src/main/scala/org/apache/spark/sql/functions.scala:
##########
@@ -4272,9 +4380,10 @@ object functions {
/**
* @param e
- * hyperbolic angle
+ * hyperbolic angle. A column that evaluates to a double.
* @return
- * hyperbolic sine of the given value, as if computed by
`java.lang.Math.sinh`
+ * hyperbolic sine of the given value, as if computed by
`java.lang.Math.sinh` Returns a
Review Comment:
The run-on sweep missed 17 `@return` blocks — here the appended sentence
still fuses onto the prior one ("...`java.lang.Math.sinh` Returns a column...")
without a separating period. The full remaining set (same fix — add a period
before "Returns"): `sinh` (4385), `tanh` (4431), `add_months` (7831),
`date_format` (7923),
`year`/`quarter`/`month`/`dayofweek`/`dayofmonth`/`dayofyear` and siblings
(8084, 8094, 8104, 8115, 8125, 8135, 8145, 8157), `last_day` (8238), and
8351/8365/8381. The other ~33 blocks were fixed correctly.
```suggestion
* hyperbolic sine of the given value, as if computed by
`java.lang.Math.sinh`. Returns a
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
