HyukjinKwon commented on code in PR #57079:
URL: https://github.com/apache/spark/pull/57079#discussion_r3555694226
##########
sql/api/src/main/scala/org/apache/spark/sql/functions.scala:
##########
@@ -8127,9 +8496,11 @@ object functions {
*
* @param s
* A date, timestamp or string. If a string, the data must be in a format
that can be cast to
- * a timestamp, such as `yyyy-MM-dd` or `yyyy-MM-dd HH:mm:ss.SSSS`
+ * a timestamp, such as `yyyy-MM-dd` or `yyyy-MM-dd HH:mm:ss.SSSS`. A
column that evaluates to
+ * a string, date, timestamp, timestamp_ntz, or numeric.
* @return
* A timestamp, or null if the input was a string that could not be cast
to a timestamp
Review Comment:
The sole `@return` run-on left after the 16-block fix: this line ends
without a period, so it fuses with "Returns a column that evaluates to a
timestamp." on the next line. My earlier comment said "17 blocks" but only
enumerated 16 line sites, and `to_timestamp` wasn't among them — so it slipped
through. Same fix as the rest:
```suggestion
* A timestamp, or null if the input was a string that could not be cast
to a timestamp.
```
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/AnyValue.scala:
##########
@@ -34,6 +34,13 @@ import org.apache.spark.sql.types._
usage = """
_FUNC_(expr[, isIgnoreNull]) - Returns some value of `expr` for a group of
rows.
If `isIgnoreNull` is true, returns only non-null values.""",
+ arguments = """
+ Arguments:
+ * expr - The expression to return some value of for a group of rows.
Review Comment:
"...some value of **for** a group of rows." reads broken — the dangling "of"
collides with the "for a group of rows" clause. The peers `first`/`last` use
"The expression to return the {first,last} value of." — suggest matching them:
```suggestion
* expr - The expression to return some value of.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
