dongjoon-hyun commented on code in PR #57242:
URL: https://github.com/apache/spark/pull/57242#discussion_r3581123698
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala:
##########
@@ -88,6 +88,17 @@ private[spark] object Config extends Logging {
.checkValues(Set("IPv4", "IPv6", "IPv4,IPv6", "IPv6,IPv4"))
.createWithDefault("IPv4")
+ val KUBERNETES_DRIVER_SERVICE_PUBLISH_NOT_READY_ADDRESSES =
+ ConfigBuilder("spark.kubernetes.driver.service.publishNotReadyAddresses")
+ .doc("If true, the driver service publishes DNS records for the driver
pod even " +
+ "while the pod is not ready, so executors can resolve the driver
service " +
+ "during startup when a readiness probe is configured on the driver
pod. " +
+ "When enabled, the driver pod readiness wait before executor
allocation " +
+ "is skipped as well.")
+ .version("4.3.0")
Review Comment:
We need `withBindingPolicy` for new configurations.
```suggestion
.version("4.3.0")
.withBindingPolicy(ConfigBindingPolicy.NOT_APPLICABLE)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
