uros-b commented on code in PR #57242: URL: https://github.com/apache/spark/pull/57242#discussion_r3587613694
########## docs/running-on-kubernetes.md: ########## @@ -1583,6 +1583,17 @@ See the [configuration page](configuration.html) for information on Spark config </td> <td>3.4.0</td> </tr> +<tr> + <td><code>spark.kubernetes.driver.service.publishNotReadyAddresses</code></td> + <td><code>false</code></td> + <td> + If true, the driver service publishes DNS records for the driver pod even while the pod + is not ready, so executors can resolve the driver service during startup when a readiness Review Comment: Note: the rationale "so executors can resolve the driver service during startup" only holds when spark.kubernetes.executor.useDriverPodIP=false. That config defaults to true (since 4.1.0+), where the executor's driverAddress is DRIVER_BIND_ADDRESS (the pod IP) and executors never DNS-resolve the driver service; so in the default configuration this option, and the readiness wait it bypasses, are moot. A user reading only this entry may enable it believing it helps the default setup. One clarifying sentence (only meaningful when useDriverPodIP=false) in both the config doc and the docs table would close the gap. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
