cloud-fan commented on code in PR #57202:
URL: https://github.com/apache/spark/pull/57202#discussion_r3581533646
##########
sql/connect/server/src/main/scala/org/apache/spark/sql/connect/config/Connect.scala:
##########
@@ -87,6 +87,49 @@ object Connect {
.intConf
.createWithDefault(ConnectCommon.CONNECT_GRPC_MARSHALLER_RECURSION_LIMIT)
+ val CONNECT_GRPC_KEEPALIVE_ENABLED =
+ buildStaticConf("spark.connect.grpc.keepAlive.enabled")
+ .doc(
+ "Whether the server sends gRPC/HTTP2 keepalive PINGs to detect and
terminate " +
+ "silently-dead client connections (see
spark.connect.grpc.keepAlive.time / " +
+ ".timeout). Enabled by default; can be turned off as an escape
hatch, e.g. if it " +
+ "interacts badly with a particular network path, or a server
environment is prone " +
+ "to stalls (long GC pauses, etc.) long enough to trip false-positive
disconnects. " +
+ "This only controls the server's own dead-client detection; the
server's tolerance " +
+ "of client-initiated keepalive PINGs (see
spark.connect.grpc.keepAlive.time) is " +
Review Comment:
The `(see spark.connect.grpc.keepAlive.time)` here points readers at the
server's own *detection* interval, but this sentence is about the *client-ping
tolerance* — which is the fixed 10s `GRPC_KEEPALIVE_PERMIT_TIME_SECONDS` floor,
independent of `keepAlive.time`. Same class of stale cross-reference you
corrected on the `keepAlive.time` doc string last round; it survives on this
sibling `.enabled` doc. Suggest dropping the parenthetical so it doesn't
misdirect:
```suggestion
"of client-initiated keepalive PINGs is " +
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
