cloud-fan commented on code in PR #57142:
URL: https://github.com/apache/spark/pull/57142#discussion_r3622381145
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -594,7 +594,7 @@ query
insertInto
: INSERT (WITH SCHEMA EVOLUTION)? OVERWRITE TABLE? identifierReference
optionsClause? (partitionSpec (IF errorCapturingNot EXISTS)?)? ((BY NAME) |
identifierList)? #insertOverwriteTable
| INSERT (WITH SCHEMA EVOLUTION)? INTO TABLE? identifierReference
optionsClause? partitionSpec? (IF errorCapturingNot EXISTS)? ((BY NAME) |
identifierList)? #insertIntoTable
- | INSERT (WITH SCHEMA EVOLUTION)? INTO TABLE? identifierReference
tableAlias optionsClause? (BY NAME)?
+ | INSERT (WITH SCHEMA EVOLUTION)? INTO TABLE? identifierReference
tableAlias optionsClause? ((BY NAME) | identifierList)?
Review Comment:
Please restrict `identifierList` to the `REPLACE WHERE` form, or reject it
explicitly in `visitInsertIntoReplaceOn`. This shared alternative also accepts
`INSERT INTO t (a, b) REPLACE ON ...`, but the ON visitor sets
`userSpecifiedCols = Seq.empty`, so the parsed list is silently ignored. A
parser test for the ON form would guard this boundary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
