gaogaotiantian commented on PR #57407: URL: https://github.com/apache/spark/pull/57407#issuecomment-5040716489
Okay this is where things get tricky. Normally we don't import `connect` related stuff in non connect directory. I think we need to figure out the actual purpose here. Whether this class is meant to be used by connect-only, or both classic and connect. Type annotation is to better-define our code, not just to pass the static checker. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
