gaogaotiantian commented on PR #57407: URL: https://github.com/apache/spark/pull/57407#issuecomment-5041042896
`Union[SparkSession, ConnectSparkSession]` is actually not the best way. The proper annotation needs some generics, otherwise the caller does not know what the returned value is. I guess that's the reason why it was ignored in the first place - like I said, there are cases where it's not easy to annotate. We can leave the question here and revert the changes to that file - if we have answers to help us move forward we can do it later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
