dongjoon-hyun commented on code in PR #57285:
URL: https://github.com/apache/spark/pull/57285#discussion_r3641959572
##########
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala:
##########
@@ -620,6 +620,10 @@ class CoarseGrainedSchedulerBackend(scheduler:
TaskSchedulerImpl, val rpcEnv: Rp
setupTokenManager()
}
+ override protected def tokenManagerRequired(): Boolean = {
+ super.tokenManagerRequired() ||
conf.get(CREDENTIALS_DIRECT_PROVIDERS_ENABLED)
Review Comment:
This makes `tokenManagerRequired()` return true for *every*
`CoarseGrainedSchedulerBackend` subclass, but only YARN, Kubernetes, and local
mode actually override `createTokenManager()`. On standalone,
`StandaloneSchedulerBackend` inherits the default `createTokenManager(): None`,
so enabling `spark.security.credentials.directProviders.enabled` there passes
the encryption `require`, flips `tokenManagerRequired()` to true — and then
`setupTokenManager()` silently does nothing. No tokens are collected, no
warning is logged, and the user has no signal that the feature is inert on
their cluster manager.
1. Please document in the PR description (and documentation) that
`StandaloneCluster` is not supported (or out of scope).
2. Log a warning in `setupTokenManager()` (or here) when the config is
enabled but `createTokenManager()` returns `None`, so make the misconfiguration
visible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
