parthchandra commented on code in PR #57285:
URL: https://github.com/apache/spark/pull/57285#discussion_r3667518197
##########
core/src/main/scala/org/apache/spark/deploy/security/HadoopDelegationTokenManager.scala:
##########
@@ -76,28 +77,52 @@ private[spark] class HadoopDelegationTokenManager(
require((principal == null) == (keytab == null),
"Both principal and keytab must be defined, or neither.")
+ if (sparkConf.get(CREDENTIALS_DIRECT_PROVIDERS_ENABLED)) {
+ val hasEncryption = sparkConf.getBoolean("spark.ssl.rpc.enabled", false) ||
+ (sparkConf.get(NETWORK_AUTH_ENABLED) &&
+ (sparkConf.get(NETWORK_CRYPTO_ENABLED) ||
sparkConf.get(SASL_ENCRYPTION_ENABLED)))
+ require(hasEncryption,
+ "RPC channel encryption must be enabled when " +
+ "spark.security.credentials.directProviders.enabled is true: either " +
+ "spark.ssl.rpc.enabled=true, or spark.authenticate=true together with " +
+ "spark.network.crypto.enabled or
spark.authenticate.enableSaslEncryption. " +
+ "Credential tokens must not be transmitted over unencrypted channels.")
Review Comment:
I believe so. It is entirely possible for a user to have Kerberos enabled
for auth but not have the rpc channel encrypted. I'm not entirely sure if
there is another secure gate that Kerberos case enables but for non-Kerberos we
definitely need to make sure that the transmission is over a secure channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
