pan3793 commented on code in PR #57468:
URL: https://github.com/apache/spark/pull/57468#discussion_r3642526097
##########
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkGetSchemasOperation.scala:
##########
@@ -78,34 +78,38 @@ private[hive] class SparkGetSchemasOperation(
// filtering deferred).
val resolvedCatalog = catalogManager.currentCatalog
val catalogNameValue = resolvedCatalog.name()
+ // Use SupportsNamespaces uniformly for all catalogs including the
session
+ // catalog (V2SessionCatalog implements SupportsNamespaces). This
avoids
+ // assuming that a spark_catalog override delegates to the built-in
session
+ // catalog.
Review Comment:
@yadavay-amzn I think we can accept this for now, as users still have a
backdoor (`isCatalogMetadataEnabled`) to go back to the old impl.
@cloud-fan for the long term, do we want to extend the V2 API to support
predication pushdown? and the approach can also be either simple - just accept
a string pattern like the current `ExternalCatalog`, or extendable - just like
`SupportsPushDownFilters`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
