cloud-fan commented on code in PR #57468:
URL: https://github.com/apache/spark/pull/57468#discussion_r3646898334
##########
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/SparkMetadataOperationSuite.scala:
##########
@@ -804,6 +804,31 @@ class SparkMetadataOperationSuite extends
HiveThriftServer2TestBase {
}
}
+ test("SPARK-57518: getSchemas for spark_catalog lists namespaces via
SupportsNamespaces " +
Review Comment:
Please exercise a custom spark_catalog override here. This test uses the
built-in V2SessionCatalog, so it returns the same schemas before and after the
production change and cannot catch restoration of the removed SessionCatalog
special case. A CatalogExtension whose listNamespaces result differs from
SessionCatalog.listDatabases would make this a regression test for the behavior
the PR fixes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
