HyukjinKwon commented on PR #57551: URL: https://github.com/apache/spark/pull/57551#issuecomment-5098118331
One minor doc-accuracy note on the PR description itself (code looks correct): The description says builders like `max_by`/`min_by` "already document `arguments`" and "were not part of the backfill." But this PR *does* add `arguments` to `MaxByBuilder` and `MinByBuilder` in `MaxMinByK.scala` (they were missing it, and the new `assert(info.getArguments.nonEmpty)` would have failed for them otherwise). The `minute`/`second` half of that sentence is accurate — those weren't touched. Suggest dropping `max_by`/`min_by` from that sentence, or moving them into the backfilled list, so the stated scope matches the diff. Otherwise LGTM: the enforcement mirrors the existing SPARK-32870 pattern (`noArgumentsSet` alongside `ignoreSet`, fail-closed), the 118 `arguments =` additions match the claim, all changes are annotation-string only (no behavior change), and the `noArgumentsSet` exemptions are all genuinely zero-arg. I verified the builder-registered functions are actually reached by the test via `FunctionRegistry.expressionBuilder`. <!-- ai-code-review --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
