cloud-fan commented on code in PR #57551:
URL: https://github.com/apache/spark/pull/57551#discussion_r3709918729
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala:
##########
@@ -55,6 +55,11 @@ trait NoThrow
*/
@ExpressionDescription(
usage = "_FUNC_(expr, ...) - Returns an array with the given elements.",
+ arguments = """
+ Arguments:
+ * expr - An expression of any type to include as an array element. One
or more
Review Comment:
`array()` and `struct()` both support zero arguments, so these descriptions
should say `zero or more`. Please update the parallel `struct` wording at
`complexTypeCreator.scala:441` as well.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala:
##########
@@ -1313,6 +1320,11 @@ object Pmod {
*/
@ExpressionDescription(
usage = "_FUNC_(expr, ...) - Returns the least value of all parameters,
skipping null values.",
+ arguments = """
+ Arguments:
+ * expr - An expression of any orderable type. All arguments must share a
common type.
Review Comment:
`least` and `greatest` require at least two arguments (`checkInputDataTypes`
rejects `children.length <= 1`). Please state that minimum here and in the
parallel `greatest` description at `arithmetic.scala:1419`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
