dongjoon-hyun commented on code in PR #57593:
URL: https://github.com/apache/spark/pull/57593#discussion_r3669025178
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -314,18 +315,17 @@ object Analyzer {
/**
* In case ANSI value wasn't persisted for a view or a UDF, we set it to
`true` in case Spark
- * version used to create the view is 4.0.0 or higher. We set it to `false`
in case Spark version
- * is lower than 4.0.0 or if the Spark version wasn't stored (in that case
we assume that the
- * value is `false`)
+ * version used to create the view is 4.0.0 or higher (ANSI SQL mode became
the default in
+ * Spark 4.0, see SPARK-44444). We set it to `false` in case Spark version
is lower than 4.0.0
+ * or if the Spark version wasn't stored / can't be parsed (in that case we
assume that the
+ * value is `false`).
*/
def trySetAnsiValue(sqlConf: SQLConf, createSparkVersion: String = ""): Unit
= {
Review Comment:
+1 for the test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
