pan3793 commented on code in PR #57593:
URL: https://github.com/apache/spark/pull/57593#discussion_r3670733075
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/resolver/ViewResolver.scala:
##########
@@ -102,7 +102,10 @@ class ViewResolver(
val (resolvedChild, usedViewResolutionContext) =
withViewResolutionContext(unresolvedView) {
SQLConf.withExistingConf(
- View.effectiveSQLConf(unresolvedView.desc.viewSQLConfigs,
unresolvedView.isTempView)
+ View.effectiveSQLConf(
+ configs = unresolvedView.desc.viewSQLConfigs,
+ isTempView = unresolvedView.isTempView,
+ createSparkVersion = unresolvedView.desc.createVersion)
Review Comment:
Fixed in bf6935d. `SessionCatalog.parseMetricViewDefinition` now forwards
`createSparkVersion = metadata.createVersion` to `View.effectiveSQLConf`,
matching `fromCatalogTable`. Pre-existing omission made visible by this PR
aligning the single-pass path; same pattern as the `ViewResolver.resolve` fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
