aokolnychyi commented on code in PR #57582:
URL: https://github.com/apache/spark/pull/57582#discussion_r3687212959
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -154,7 +154,8 @@ case class AnalysisContext(
resolutionPathEntries: Option[Seq[Seq[String]]] = None,
nestedViewDepth: Int = 0,
maxNestedViewDepth: Int = -1,
- relationCache: mutable.Map[(Seq[String], Option[TimeTravelSpec]),
LogicalPlan] =
+ relationCache:
+ mutable.Map[(Seq[String], Option[TimeTravelSpec],
CaseInsensitiveStringMap), LogicalPlan] =
Review Comment:
Question: Is there a good place where we can put a helper container? I see
`RelationResolution` has the same triple dependency.
Also, is it feasible to promote RelationId from the single pass analyzer to
AnalysisContext and use it as cache key in both analyzers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
