yyanyy commented on code in PR #57582:
URL: https://github.com/apache/spark/pull/57582#discussion_r3687424596
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -154,7 +154,8 @@ case class AnalysisContext(
resolutionPathEntries: Option[Seq[Seq[String]]] = None,
nestedViewDepth: Int = 0,
maxNestedViewDepth: Int = -1,
- relationCache: mutable.Map[(Seq[String], Option[TimeTravelSpec]),
LogicalPlan] =
+ relationCache:
+ mutable.Map[(Seq[String], Option[TimeTravelSpec],
CaseInsensitiveStringMap), LogicalPlan] =
Review Comment:
Extracted the triple dependency to `RelationCacheKey` in a new file
following examples of `RelationCache` and `RelationId` as neither
AnalysisContext nor RelationResolution owns the key.
For promoting `RelationId` to be the shared key - will follow up with
another PR on this since it's not a trivial change, as the two keys in both
analyzers have some overlap but also diverge on the rest, e.g. `isStreaming`,
and didn't want to increase the scope of this PR by too much
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
