sarutak commented on code in PR #57655:
URL: https://github.com/apache/spark/pull/57655#discussion_r3688473588
##########
pom.xml:
##########
@@ -3519,6 +3519,13 @@
</modules>
</profile>
+ <profile>
+ <id>credential-aws</id>
+ <modules>
+ <module>connector/credential-aws</module>
Review Comment:
Since introducing a new Maven profile requires updates to many
CI/release/lint scripts, I'd like to split the module scaffolding (SPARK-57897)
into a separate PR as originally planed. I'll handle it. It will include:
- Module definition (`connector/credential-aws/pom.xml` with a stub provider)
- `pom.xml` profile, `SparkBuild.scala`, `modules.py`, `utils.py`
- `META-INF/services` registration
- CI/release/lint script updates:
- `.github/workflows/build_and_test.yml`
- `.github/workflows/maven_test.yml`
- `.github/workflows/python_hosted_runner_test.yml`
- `.github/workflows/benchmark.yml`
- `dev/create-release/release-build.sh`
- `dev/test-dependencies.sh`
- `dev/mima`
- `dev/lint-java`
- `dev/sbt-checkstyle`
- `dev/scalastyle`
- `docs/_plugins/build_api_docs.rb`
- `dev/spark-test-image-util/docs/build-docs`
Once that's merged, this PR can focus purely on the
`AwsStsCredentialProvider` implementation and tests, removing the build wiring
changes from its diff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]