yadavay-amzn commented on PR #57655:
URL: https://github.com/apache/spark/pull/57655#issuecomment-5222673398
Thanks again for reviewing @dongjoon-hyun
1. Cause-chain redaction: walks the full chain now, and drops the original
entirely when the token appears anywhere; new test constructs a token planted
only in a nested cause and asserts every layer is scrubbed.
2. `@DeveloperApi` removal is intentional (SPI implementation, not itself
public API); called out in the PR description now, `@since 4.3.0` kept in the
Javadoc.
3. Configured `sessionName` is validated against `[\w+=,.@-]{2,64}` in
`init()`; IAE names the config key on any mismatch.
4. `@AfterEach` closes a suite-level provider field, so the tests going
through real `init()` no longer leak `StsClient` handles.
5. `resolve()` catches `IllegalStateException` narrowly (post-close case)
and wraps in `CredentialResolutionException`.
6. Docs follow-up is tracked as
[SPARK-57901](https://issues.apache.org/jira/browse/SPARK-57901) (Add
documentation about OIDC Credential Propagation); pointer added to the PR
description. These 5 `spark.security.oidc.aws.*` keys will land there alongside
the other OIDC keys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
