uros-b commented on code in PR #57629:
URL: https://github.com/apache/spark/pull/57629#discussion_r3689579803
##########
sql/core/src/test/resources/sql-tests/inputs/distinct-map-aggregates.sql:
##########
Review Comment:
The alias-reuse branch specifically isn't exercised end to end: no query
groups by the same map column it also counts distinct, so
existingAliases.getOrElse(...) and the groupingMapSortAliases ++
distinctMapSortAliases merge never run. The GROUP BY m case uses
named_struct('m', m, 'n', n), which takes the fresh-alias path. SELECT m,
COUNT(DISTINCT m) FROM t GROUP BY m would cover it and would catch a duplicated
MapSort if the reuse ever regressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
