uros-b commented on code in PR #57629: URL: https://github.com/apache/spark/pull/57629#discussion_r3689580762
########## sql/core/src/test/resources/sql-tests/analyzer-results/distinct-map-aggregates.sql.out: ########## Review Comment: The golden files verify results, which is the important half, but analyzer-results shows the analyzed plan, so none of the new machinery appears in any test: the two-level Project, the grouping-alias reuse, and the dedup of identical distinct arguments have no plan-level assertion. There's no PlanTest suite for this rule today; adding one, or at minimum a DataFrameAggregateSuite test asserting a single MapSort in the optimized plan, would pin down the part of the change that carries the risk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
