uros-b commented on code in PR #57476: URL: https://github.com/apache/spark/pull/57476#discussion_r3700455220
########## sql/core/src/test/resources/sql-tests/inputs/math.sql: ########## Review Comment: The no-overflow property isn't pinned down anywhere. round/bround carry boundary cases like bround(-9223372036854775808L, -1) that throw under ANSI. The mirror-image truncate cases would document in the ANSI golden that truncate never overflows — truncate(-128y, -1) is -120 while round(-128y, -1) overflows tinyint. Two lines, and it captures the most notable property of the new function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
