SreeramaYeshwanthGowd commented on PR #57476: URL: https://github.com/apache/spark/pull/57476#issuecomment-5160878127
Thanks for the very thorough review, addressed all of it. math.sql now has negative inputs for every type and scale, showing truncation toward zero (e.g. truncate(-25y, -1) is -20). Added truncate(127y, -1) and truncate(-128y, -1) to document that truncate never overflows, unlike round. Added truncate(1234.5678) with no scale argument. MathFunctionsSuite now covers the truncate(Column, Int) and truncate(Column) overloads, a decimal column (the type that needed the new Decimal.changePrecision mode), and NaN and Infinity, which are returned unchanged. Fixed the comment indentation in Decimal.scala. Added comments explaining that ansiEnabled is inert for Truncate and that the inherited decimal precision widening is expected. Fixed the PySpark docstring wording for decimal outputs and added trunc, floor, and ceil to See Also. Also reordered the return tag to come before group and since in functions.scala. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
