uros-b commented on code in PR #57300:
URL: https://github.com/apache/spark/pull/57300#discussion_r3700491508
##########
sql/connect/server/src/test/scala/org/apache/spark/sql/connect/SessionQueryTest.scala:
##########
@@ -33,14 +33,14 @@ import org.apache.spark.sql
* This trait overrides [[spark]] to use a [[SparkSession
connect.SparkSession]], which executes
* via the gRPC API using an in-process connect server.
*/
-trait SessionQueryTest extends sql.SessionQueryTest with SparkSessionBinder {
+trait SessionQueryTest extends sqlCore.SessionQueryTest with
SparkSessionBinder {
Review Comment:
The rename is only needed because the inherited sql member shadows the
org.apache.spark.sql package name inside the trait body; the extends
sql.SessionQueryTest clause resolves in the enclosing scope and would have been
fine on its own (compare classic.QueryTest, which keeps import
org.apache.spark.sql and refers to sql.QueryTest in its extends clause).
Importing DataFrame directly, or fully qualifying the single body reference,
would keep this to one line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
