fwc commented on code in PR #57300:
URL: https://github.com/apache/spark/pull/57300#discussion_r3707545571


##########
sql/core/src/test/scala/org/apache/spark/sql/SparkSessionProvider.scala:
##########
@@ -26,4 +26,9 @@ package org.apache.spark.sql
  */
 trait SparkSessionProvider {
   protected def spark: SparkSession
+
+  /**
+   * Shorthand for running a query using the [[SparkSession]]
+   */
+  protected def sql(query: String): DataFrame = spark.sql(query)

Review Comment:
   > should connect.SparkSessionProvider do the same?
   
   Err yes, quite surely, would be weird if `spark.sql` would return something 
different than `sql`.
   
   Thx for the catch :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to